Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default branch properly #263

Merged
merged 3 commits into from Dec 17, 2020

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Dec 6, 2020

Hi,

Thank you for cargo-generate ❤️

I would like to introduce this change to make cargo-generate more friendly with repositories that don't use "master" as the default branch. I think this is particularly relevant now that GitHub also uses "main" instead of "master".

I would have like to fix it on cargo directly but there are some compatibility issues. But I don't think this is an issue for cargo-generate. This is why I'm introducing this change here.

I was personally bothered by it because I tried to make a new template but it failed because I was using the "main" branch as default branch.

@k0pernicus
Copy link
Collaborator

Hi @cecton, thanks for the update!

Everything is ok on my side - any comment(s) @sassman or I can merge it? :)

@sassman
Copy link
Member

sassman commented Dec 17, 2020

@k0pernicus unfortunately I cannot merge it, lacking the privileges. But looks good for me.

@k0pernicus k0pernicus merged commit 1576f16 into cargo-generate:master Dec 17, 2020
@k0pernicus
Copy link
Collaborator

Thanks again @cecton, and welcome as a contributor! :)

@cecton cecton deleted the default-branch-main branch December 17, 2020 16:22
@cecton
Copy link
Contributor Author

cecton commented Dec 17, 2020

Thanks a lot! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants