Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

letting engine to optimize typeof comparisons #78

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@caridy
Copy link
Owner

caridy commented Mar 18, 2020

Based on some feedback from @ljharb on #77 (comment), we can now validate that in seems that the parser can understand better the intent and optimize the comparison (to avoid string comparison) when the typeof is inline.

@ljharb
ljharb approved these changes Mar 18, 2020
@caridy caridy merged commit 23d7dac into master Mar 18, 2020
@caridy caridy deleted the caridy/typeof-optimizations branch Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.