Reduce trailing churn#1046
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc12d9f44d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| symbolPnl.set( | ||
| bot.pair, | ||
| (symbolPnl.get(bot.pair) ?? 0) + getNetProfit(bot), | ||
| ); |
There was a problem hiding this comment.
When the dashboard has bots with materially different order sizes, this concentration calculation misstates exposure because getNetProfit(bot) returns a percentage return from computeSingleBotProfit, not a currency PnL amount. A $10 bot up 20% and a $10,000 bot up 1% will be counted as 20 vs 1 here, even though the larger bot dominates actual PnL, so the top-symbol share/HHI can point operators at the wrong concentration risk.
Useful? React with 👍 / 👎.
1 participant
No description provided.