New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send vehicle control commands only when reciving ROS input #22

Merged
merged 3 commits into from Jan 7, 2019

Conversation

3 participants
@fabianoboril
Copy link
Member

fabianoboril commented Jan 3, 2019

With this commit, the CARLA-ROS-bridge sends vehicle control commands to CARLA,
only when there is input from the ROS side.

This solves Issue #20

Tested with CARLA 0.9.2 on Ubuntu 16.04


This change is Reviewable

Send vehicle control commands only when reciving ROS input
With this commit, the CARLA-ROS-bridge sends vehicle control commands to CARLA,
only when there is input from the ROS side.

@fabianoboril fabianoboril requested a review from berndgassmann Jan 3, 2019

@fabianoboril
Copy link
Member Author

fabianoboril left a comment

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

@anshulpaigwar
Copy link
Contributor

anshulpaigwar left a comment

Comment the print statement in my system it continuously printing empty list [ ]

Show resolved Hide resolved src/carla_ros_bridge/ego_vehicle.py Outdated
Show resolved Hide resolved src/carla_ros_bridge/ego_vehicle.py Outdated
@fabianoboril
Copy link
Member Author

fabianoboril left a comment

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anshulpaigwar and @berndgassmann)


src/carla_ros_bridge/ego_vehicle.py, line 167 at r1 (raw file):

Previously, anshulpaigwar (Anshul Paigwar) wrote…
        # print(ros_control_topic)

Continously printing empty list

Done.


src/carla_ros_bridge/ego_vehicle.py, line 169 at r1 (raw file):

Previously, anshulpaigwar (Anshul Paigwar) wrote…
        # print(ros_control_topic)

same continiously printing empty list

Done.

@fabianoboril

This comment has been minimized.

Copy link
Member Author

fabianoboril commented Jan 6, 2019

@anshulpaigwar : Thanks for having a look. The print statements shouldn't be in, I removed them.

@berndgassmann
Copy link
Contributor

berndgassmann left a comment

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anshulpaigwar)

@berndgassmann
Copy link
Contributor

berndgassmann left a comment

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anshulpaigwar)

@berndgassmann
Copy link
Contributor

berndgassmann left a comment

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anshulpaigwar)

@fabianoboril fabianoboril merged commit e69570c into master Jan 7, 2019

1 check was pending

code-review/reviewable 2 discussions left (anshulpaigwar)
Details

@fabianoboril fabianoboril deleted the fix/vehicleControl branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment