Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop the with-deprecated cfg and everything behind it #655
Comments
carllerche
added
the
help wanted
label
Aug 18, 2017
This comment has been minimized.
This comment has been minimized.
|
I'm working on this, (perhaps slowly). |
This was referenced Aug 20, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Aug 24, 2017
ahmedcharles
referenced this issue
Aug 24, 2017
Merged
Ensure that tests pass without default features. #717
alexcrichton
closed this
in
#717
Aug 25, 2017
alexcrichton
added a commit
that referenced
this issue
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dtolnay commentedAug 18, 2017
As I understand it, the only thing blocking this is reimplementing the test cases that currently rely on deprecated functionality.
The best way to approach this would be running
cargo test --no-default-featuresto see what breaks:then reworking small self-contained pieces to use the new APIs. I imagine this will be split across lots of PRs. It also sounds like a great way to learn the ins and outs of mio in general!
Once
cargo test --no-default-featurespasses, we can rip out all the deprecated functionality.