Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove the implementations of std::ops::Not #656
Comments
carllerche
added
the
help wanted
label
Aug 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Before doing this, the git history should be checked for any potential info on why it was originally added. |
This comment has been minimized.
This comment has been minimized.
|
The impl for PollOpt was added in: 0122914 It doesn't seem to explain why. |
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Aug 23, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Aug 24, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Aug 28, 2017
carllerche
added a commit
to ahmedcharles/mio
that referenced
this issue
Aug 31, 2017
carllerche
closed this
in
#714
Aug 31, 2017
carllerche
added a commit
that referenced
this issue
Aug 31, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Sep 12, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Nov 7, 2017
ahmedcharles
added a commit
to ahmedcharles/mio
that referenced
this issue
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dtolnay commentedAug 18, 2017
From what I can tell, the only reason these exists is to be used in the implementation of Sub and SubAssign.
Other than in Sub, it never makes sense to apply Not to a Ready. You would never call Poll::register and pass the Not of a Ready, for example. Let's reimplement Sub in a different way and remove the semantically meaningless Not operation.
Applies to Ready, UnixReady, FuchsiaReady, and PollOpt.