Skip to content

/mio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `?` in examples, not `try!`, not unwrap() #666

Closed
dtolnay opened this Issue Aug 18, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @carllerche
@dtolnay
Copy link

dtolnay commented Aug 18, 2017

Per the c-question-mark guideline.

The following ripgrep search shows tons of examples in mio using unwrap().

rg ' */// [^#].*unwrap\(\).*'

@carllerche carllerche added the help wanted label Aug 18, 2017

ahmedcharles added a commit to ahmedcharles/mio that referenced this issue Aug 20, 2017

@ahmedcharles
Don't use try or unwrap in examples. 
Fixes carllerche#666.
4feef24

@ahmedcharles ahmedcharles referenced this issue Aug 20, 2017

Merged

Don't use try or unwrap in examples. #689

@alexcrichton alexcrichton closed this in #689 Aug 20, 2017

alexcrichton added a commit that referenced this issue Aug 20, 2017

@ahmedcharles @alexcrichton
Don't use try or unwrap in examples. (#689) 
Fixes #666.
Loading status checks…
620e4c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.