SocketAddr argument to UdpSocket methods

[dtolnay]

fn bind(addr: &SocketAddr) -> Result<UdpSocket>;
fn connect(&self, addr: SocketAddr) -> Result<()>;

One of these takes a &SocketAddr, the other takes SocketAddr by value. If possible, they should be consistent.

[bobbo]

I'd like to take a look at doing this.

UdpSocket::bind(), UdpSocket::send_to() and TcpStream::connect() take SocketAddr by ref, so that seems the most consistent way to go.

[asayers]

Or better yet, generalise addr to ToSocketAddrs like the equivalent libstd functions do. This way, it wouldn't even be a breaking change.

EDIT: Well, it's still breaking since it can introduce ambiguity errors.

EDIT: Never mind, I just noticed #668.