Skip to content

/mio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug representation of empty PollOpt #669

Closed
dtolnay opened this Issue Aug 18, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @carllerche
@dtolnay
Copy link

dtolnay commented Aug 18, 2017

Currently PollOpt::empty() has an empty debug representation.

// the empty string
format!("{:?}", PollOpt::empty())

This is not very debuggable. Let's pick something more helpful like we did in bitflags/bitflags#64.

@carllerche carllerche added the help wanted label Aug 18, 2017

ahmedcharles added a commit to ahmedcharles/mio that referenced this issue Aug 20, 2017

@ahmedcharles
Use (empty) as debug representation of PollOpt::empty(). 
Fixes carllerche#669.
64d316e

@ahmedcharles ahmedcharles referenced this issue Aug 20, 2017

Merged

Use (empty) as debug representation of PollOpt::empty(). #690

ahmedcharles added a commit to ahmedcharles/mio that referenced this issue Aug 20, 2017

@ahmedcharles
Use (empty) as debug representation of PollOpt::empty(). 
Fixes carllerche#669.
dc2d5ea

@alexcrichton alexcrichton closed this in #690 Aug 22, 2017

alexcrichton added a commit that referenced this issue Aug 22, 2017

@ahmedcharles @alexcrichton
Use (empty) as debug representation of PollOpt::empty(). (#690) 
Fixes #669.
Loading status checks…
8eec1ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.