Skip to content

/mio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug representation of Ready vs PollOpt #672

Closed
dtolnay opened this Issue Aug 18, 2017 · 0 comments

Comments

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
2 participants
@dtolnay @carllerche
@dtolnay
Copy link

dtolnay commented Aug 18, 2017

Ready and PollOpt currently have different-looking Debug for no clear reason.

// Ready {Readable | Writable}
println!("{:?}", Ready::readable() | Ready::writable());

// Level-Triggered | OneShot
println!("{:?}", PollOpt::level() | PollOpt::oneshot());

I don't have a preference but let's make these consistent.

@carllerche carllerche added the help wanted label Aug 18, 2017

ahmedcharles added a commit to ahmedcharles/mio that referenced this issue Aug 20, 2017

@ahmedcharles
Have consistent debug representation for opaque structs. 
Fixes carllerche#671.
Fixes carllerche#670.
Fixes carllerche#672.
6ee10e4

@ahmedcharles ahmedcharles referenced this issue Aug 20, 2017

Merged

Have consistent debug representation for opaque structs. #691

ahmedcharles added a commit to ahmedcharles/mio that referenced this issue Aug 20, 2017

@ahmedcharles
Have consistent debug representation for opaque structs. 
Fixes carllerche#671.
Fixes carllerche#670.
Fixes carllerche#672.
eee26bf

@alexcrichton alexcrichton closed this in #691 Aug 20, 2017

alexcrichton added a commit that referenced this issue Aug 20, 2017

@ahmedcharles @alexcrichton
Have consistent debug representation for opaque structs. (#691) 
Fixes #671.
Fixes #670.
Fixes #672.
Loading status checks…
3e1c5e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.