Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrub for broken links #683

Closed
dtolnay opened this Issue Aug 19, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@dtolnay
Copy link

dtolnay commented Aug 19, 2017

The documentation of mio::event::Event has one: [readiness state]. I recall noticing a few others. Let's go through systematically and clean these up.


selection_060

@dtolnay

This comment has been minimized.

Copy link
Author

dtolnay commented Aug 19, 2017

This can happen in two phases -- it would be a huge help if someone could run through the docs and make a list of the broken links in a comment here, then they can be fixed in bulk. Even going through part of the docs would be helpful. Just let us know which parts you covered.

Bonus points for implementing a warning in rustdoc to catch these automatically!

@dtolnay

This comment has been minimized.

Copy link
Author

dtolnay commented Aug 19, 2017

[set_readiness] and [portability] are broken in mio::Registration.

@mayhewj

This comment has been minimized.

Copy link
Contributor

mayhewj commented Aug 23, 2017

I went through every page on the docs and fixed most of them. The only problem I ran into is that Events is exported as both mio::Events and mio::event::Events and I can only get the links on one of them working due to needing the ../ prefix for the mio::event::Events one.

I'm not too familiar with how links work in Rust docs and couldn't find any documentation on this. Any suggestions on how we could handle this?

@dtolnay

This comment has been minimized.

Copy link
Author

dtolnay commented Aug 23, 2017

I don't know either. For now pick one of the pages to make correct. Also make sure there is a rustdoc issue to make this possible to handle correctly and/or to document how to handle this correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.