Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUse (empty) as debug representation of PollOpt::empty(). #690
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks! Could you add a test for this? |
ahmedcharles
force-pushed the
ahmedcharles:pollopt
branch
from
64d316e
to
dc2d5ea
Aug 20, 2017
This comment has been minimized.
This comment has been minimized.
|
The test failure seems unrelated. |
alexcrichton
closed this
Aug 21, 2017
alexcrichton
reopened this
Aug 21, 2017
This comment has been minimized.
This comment has been minimized.
|
Let's rerun those tests... |
alexcrichton
merged commit 8eec1ff
into
carllerche:master
Aug 22, 2017
ahmedcharles
deleted the
ahmedcharles:pollopt
branch
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ahmedcharles commentedAug 20, 2017
Fixes #669.