Skip to content

/mio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of the deprecated tcp module. #692

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ahmedcharles @alexcrichton
@ahmedcharles
Copy link
Collaborator

ahmedcharles commented Aug 20, 2017

#655
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Contributor

alexcrichton commented Aug 20, 2017

Thanks! For backwards compatibility though could this defer the actual deletion until later? For now I think we mainly just want to remove it's usage, not the deprecated pieces themselves yet
@ahmedcharles

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

ahmedcharles commented Aug 20, 2017

Sure.
@ahmedcharles

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

ahmedcharles commented Aug 20, 2017

I decided to split it into a few PR's to make reviews easier.

@ahmedcharles ahmedcharles force-pushed the ahmedcharles:deprecate branch 3 times, most recently from f99741c to ee8aed1 Aug 20, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Contributor

alexcrichton commented Aug 21, 2017

Thanks so much for doing this! Looks like the Windows tests are failing though?
@ahmedcharles

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

ahmedcharles commented Aug 22, 2017

I don't see any correlation between the failures and any changes I made. I'll probably push PR's for each commit so I can see which one causes the failure and perhaps that will bring more insight.

@ahmedcharles ahmedcharles force-pushed the ahmedcharles:deprecate branch from ee8aed1 to d29d637 Aug 22, 2017

@ahmedcharles ahmedcharles changed the title Start removing deprecated functionality. Remove uses of the deprecated tcp module. Aug 22, 2017

@ahmedcharles

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

ahmedcharles commented Aug 22, 2017

I'll just have a PR for each commit, at least for ones without merge conflicts.

@ahmedcharles ahmedcharles closed this Aug 22, 2017

@ahmedcharles ahmedcharles reopened this Aug 22, 2017

@ahmedcharles

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

ahmedcharles commented Aug 22, 2017

Rerunning the tests, since there was a docker failure.

@alexcrichton alexcrichton merged commit d6f9e10 into carllerche:master Aug 22, 2017
2 checks passed

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahmedcharles ahmedcharles deleted the ahmedcharles:deprecate branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.