Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upChange test_local_addr_ready to use Poll API. #702
Conversation
ahmedcharles
closed this
Aug 22, 2017
ahmedcharles
reopened this
Aug 22, 2017
This comment has been minimized.
This comment has been minimized.
|
Rerun the tests. |
This comment has been minimized.
This comment has been minimized.
|
Looks great! Merge conflict though now? |
ahmedcharles
force-pushed the
ahmedcharles:local_addr_ready
branch
from
528d7b7
to
56a40a7
Aug 22, 2017
This comment has been minimized.
This comment has been minimized.
|
Resolved. |
alexcrichton
closed this
Aug 22, 2017
alexcrichton
reopened this
Aug 22, 2017
alexcrichton
merged commit fdf8a4e
into
carllerche:master
Aug 22, 2017
ahmedcharles
deleted the
ahmedcharles:local_addr_ready
branch
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ahmedcharles commentedAug 22, 2017
No description provided.