Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove ops::Not impl's. #714
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. This can't actually be deleted yet as it would be a breaking change. It can be flagged as deprecated and scheduled for removal later. That said, before this is actually deprecated, I'd like to check the repo history to see if there is any info about it when it was added. |
This comment has been minimized.
This comment has been minimized.
|
Alright. Seems fine to mark as deprecated. |
ahmedcharles
force-pushed the
ahmedcharles:not
branch
2 times, most recently
from
3595fca
to
e233365
Aug 24, 2017
This comment has been minimized.
This comment has been minimized.
|
I somehow pushed the wrong code last time, this should only deprecate the impl's, not remove them. |
carllerche
force-pushed the
ahmedcharles:not
branch
from
e233365
to
aa7e104
Aug 31, 2017
This comment has been minimized.
This comment has been minimized.
|
I rebased against master, which includes the CI fix. |
carllerche
merged commit 294c0a8
into
carllerche:master
Aug 31, 2017
ahmedcharles
deleted the
ahmedcharles:not
branch
Sep 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ahmedcharles commentedAug 23, 2017
Fixes #656.