Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure errors on TCP writes happen on Windows #725
Conversation
alexcrichton
force-pushed the
alexcrichton:windows-write-error
branch
2 times, most recently
from
e9c0bb3
to
d196831
Sep 5, 2017
alexcrichton
force-pushed the
alexcrichton:windows-write-error
branch
from
d196831
to
14ed3b5
Sep 13, 2017
alexcrichton
requested a review
from
carllerche
Sep 13, 2017
carllerche
approved these changes
Sep 13, 2017
alexcrichton
merged commit 5b9d20c
into
carllerche:master
Sep 13, 2017
alexcrichton
deleted the
alexcrichton:windows-write-error
branch
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedSep 5, 2017
•
edited
Previously an error in a TCP write might accidentally get covered up as the
writefunction didn't check forState::Error. This updates that logic topropagate the error out to ensure if we see an error it goes upwards.
Closes tokio-rs/tokio-core#243