Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upModify UdpSocket::connect() to take SocketAddr by ref (#667) #731
Conversation
This comment has been minimized.
This comment has been minimized.
KodrAus
commented
Sep 19, 2017
|
Thanks @bobbo! This looks good to me |
This comment has been minimized.
This comment has been minimized.
|
This is unfortunately a breaking change :( So, this can't be merged until an 0.7 release is planned. or |
carllerche
added this to the v0.7 milestone
Oct 11, 2017
This comment has been minimized.
This comment has been minimized.
|
If you are up for it, could you rebase this against the |
bobbo
force-pushed the
bobbo:issue-667
branch
from
f677e29
to
55633d4
Nov 18, 2017
bobbo
changed the base branch from
master
to
v0.7.x
Nov 18, 2017
bobbo
force-pushed the
bobbo:issue-667
branch
from
55633d4
to
059bcab
Nov 18, 2017
This comment has been minimized.
This comment has been minimized.
|
Hi @carllerche, I've rebased on top of |
carllerche
merged commit 667b7a2
into
carllerche:v0.7.x
Nov 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bobbo commentedSep 19, 2017
Change argument for
UdpSocket::connect()to take&SocketAddr. This is more consistent with otherUdpSocketmethods, plus theTcpSocket::connect()method. Closes issue #667.