Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd TcpListener::accept_std #733
Conversation
alexcrichton
force-pushed the
alexcrichton:raw-accept
branch
from
38917e0
to
09a7df9
Sep 26, 2017
carllerche
merged commit 878bee8
into
carllerche:master
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedSep 21, 2017
This commit adds an
accept_stdmethod toTcpListenerwhich is added withthe intention of helping downstream libraries improve interoperability without
exposing
mioas a public dependency. TheTcpStreamtype is alreadyconvertible from a raw
std::net::TcpStream, so it should be possible toquickly reassociate this socket back with mio.