Add TcpListener::accept_std #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an `accept_std` method to `TcpListener` which is added with the intention of helping downstream libraries improve interoperability without exposing `mio` as a public dependency. The `TcpStream` type is already convertible from a raw `std::net::TcpStream`, so it should be possible to quickly reassociate this socket back with mio.
alexcrichton
force-pushed
the
raw-accept
branch
from
38917e0
to
09a7df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an
accept_stdmethod toTcpListenerwhich is added withthe intention of helping downstream libraries improve interoperability without
exposing
mioas a public dependency. TheTcpStreamtype is alreadyconvertible from a raw
std::net::TcpStream, so it should be possible toquickly reassociate this socket back with mio.