Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid runtime panics in IoVec on Windows #747
Conversation
jolhoeft
reviewed
Oct 14, 2017
src/sys/windows/tcp.rs
Outdated
| @@ -246,7 +246,11 @@ impl TcpStream { | |||
| } | |||
|
|
|||
| pub fn read(&self, buf: &mut [u8]) -> io::Result<usize> { | |||
| self.readv(&mut [buf.into()]) | |||
| if buf.len() > 0 { | |||
| self.readv(&mut [buf.into()]) | |||
This comment has been minimized.
This comment has been minimized.
jolhoeft
Oct 14, 2017
•
Would it be better to IoVec::from_bytes_mut here? And in the write method below?
This comment has been minimized.
This comment has been minimized.
alexcrichton
force-pushed the
alexcrichton:iovec-panic
branch
from
02f08fd
to
05cca34
Oct 15, 2017
alexcrichton
force-pushed the
alexcrichton:iovec-panic
branch
from
05cca34
to
c394a13
Oct 15, 2017
fuchsnj
referenced this pull request
Oct 16, 2017
Closed
Currently broken on Windows: dependency panics #177
carllerche
merged commit ad9911f
into
carllerche:master
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alexcrichton commentedOct 14, 2017
•
edited
Closes #746