Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a lowercase to all the mio names. #752

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@dethoter
Copy link
Contributor

dethoter commented Oct 27, 2017

Fix for #679.

@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Nov 7, 2017

Thanks for contrib 👍

I think that "Mio" should be treated as a proper noun at this point (capitalizing the first letter).

Capitalization has changed over time due to what the "Mio" name meant. It has converged to being a proper noun.

@KodrAus

This comment has been minimized.

Copy link

KodrAus commented Nov 7, 2017

Maybe we should update the references in the README too. There are a few different ways the lib is referred to in there:

  • mio
  • mio
  • MIO
@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Nov 7, 2017

Updating the README would be good too, however, mio refers to the crate literal (what is imported).

@dethoter

This comment has been minimized.

Copy link
Contributor Author

dethoter commented Dec 1, 2017

Closing this PR since changes are senseless.

@dethoter dethoter closed this Dec 1, 2017

@KodrAus

This comment has been minimized.

Copy link

KodrAus commented Dec 1, 2017

@dethoter I don't think these changes are senseless, and am glad you got stuck in and made them! It's subtle but significant to have consistent naming.

@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Dec 1, 2017

Yeah, I don't think it is senseless either, it is pretty subtle :)

@dethoter

This comment has been minimized.

Copy link
Contributor Author

dethoter commented Dec 2, 2017

Apologize, I haven't been clear enough. @carllerche decided that

"Mio" should be treated as a proper noun

Here I changed Mio to mio that's incorrect according to accepted decision. So exactly this PR is senseless. I'll open a new one to update README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.