Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upApply a lowercase to all the mio names. #752
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for contrib I think that "Mio" should be treated as a proper noun at this point (capitalizing the first letter). Capitalization has changed over time due to what the "Mio" name meant. It has converged to being a proper noun. |
This comment has been minimized.
This comment has been minimized.
KodrAus
commented
Nov 7, 2017
|
Maybe we should update the references in the README too. There are a few different ways the lib is referred to in there:
|
This comment has been minimized.
This comment has been minimized.
|
Updating the README would be good too, however, |
This comment has been minimized.
This comment has been minimized.
|
Closing this PR since changes are senseless. |
dethoter
closed this
Dec 1, 2017
This comment has been minimized.
This comment has been minimized.
KodrAus
commented
Dec 1, 2017
|
@dethoter I don't think these changes are senseless, and am glad you got stuck in and made them! It's subtle but significant to have consistent naming. |
This comment has been minimized.
This comment has been minimized.
|
Yeah, I don't think it is senseless either, it is pretty subtle :) |
This comment has been minimized.
This comment has been minimized.
|
Apologize, I haven't been clear enough. @carllerche decided that
Here I changed |
dethoter commentedOct 27, 2017
Fix for #679.