Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure html_root_url is kept in sync #754
Conversation
mgeisler
force-pushed the
mgeisler:version-sync
branch
from
364e1fc
to
a10eb8a
Nov 3, 2017
This comment has been minimized.
This comment has been minimized.
|
This might be more complicated than I hoped since version-sync doesn't support Rust 1.14 (version 1.15 is the oldest it can be compiled on). |
mgeisler
force-pushed the
mgeisler:version-sync
branch
from
a10eb8a
to
cdc2e97
Nov 3, 2017
This comment has been minimized.
This comment has been minimized.
|
Please let me know if there's any interest in the general approach — then I can see about removing the version-sync dependency on versions and targets where it doesn't work (remove with |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. I'd rather not add another dependency and instead deal with this by having a |
carllerche
closed this
Nov 7, 2017
This comment has been minimized.
This comment has been minimized.
twmb
commented
Nov 8, 2017
•
|
As an alternative, I've used before_install: |
version=$(grep "^version =" Cargo.toml | sed -r 's/^[^0-9]*([0-9]+.[0-9]+.[0-9]+).*/\1/') &&
docs_version=$(grep -R 'docs\.rs' src | head -n 1 | sed -r 's/^[^0-9]*([0-9]+.[0-9]+.[0-9]+).*/\1/') &&
test "$version" == "$docs_version"in my .travis.yml in the past. This only catches the first mismatch, but it could be cleaned up to catch all mismatches. But, waiting for upstream fixes is |
This comment has been minimized.
This comment has been minimized.
|
@carllerche Sure, no problem. Note that it's only a new dev-dependency, so only people who run the MIO tests are affected by this. I'll see about making another PR that at least fixes the outdated version number :-) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I've submitted #760 to fix the version number. |
mgeisler commentedNov 1, 2017
This adds two new unit tests: one that checks that the html_root_url
attribute always uses the current crate version number, and one that
checks that the TOML code blocks in the README use the correct version
number.
This is implemented by my version-sync crate -- I hope it's useful!
Fixes #613.