Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump slab to 0.4 #768

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@ignatenkobrain
Copy link
Contributor

ignatenkobrain commented Dec 1, 2017

No description provided.

@ignatenkobrain ignatenkobrain force-pushed the ignatenkobrain:patch-2 branch from 97dbf49 to c0c78ce Dec 1, 2017

@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Dec 2, 2017

Thanks for the PR. It doesn't look like CI is happy with it. However, since slab is only used in deprecated code (I think), maybe it isn't worth trying to update the crate?

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor Author

ignatenkobrain commented Dec 3, 2017

Okay, seems that many crates depend on slab 0.3, so I will create additionalversion of that in Fedora.

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor Author

ignatenkobrain commented Dec 3, 2017

But it would be still nice to update it, because tokio-core requires slab0.4 and mio which requires slab0.3..

deps: update slab to 0.4
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>

@ignatenkobrain ignatenkobrain force-pushed the ignatenkobrain:patch-2 branch from c0c78ce to e327ff6 Jan 10, 2018

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor Author

ignatenkobrain commented Jan 10, 2018

@carllerche so the new version of mio didn't remove dependency and it is blocking me from packaging mio in Fedora... So I spent some time and ported it.. Please review this PR ;)

@carllerche
Copy link
Owner

carllerche left a comment

I only did a quick skim, but it seemed at a glance that the change is more extensive than I think it should be.

At the very least, it looks like it is removing public types, which cannot be done in patch releases.

I would ask that all public types stay and the diff be reduced to the minimum necessary to bump the version.



#[derive(Debug)]
pub struct TimerError {

This comment has been minimized.

@carllerche

carllerche Jan 26, 2018

Owner

Why is this removed?

@briansmith

This comment has been minimized.

Copy link
Contributor

briansmith commented Feb 27, 2018

@ignatenkobrain Any chance that you could update this? If not, do you mind if I take it over?

@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Mar 8, 2018

Thanks for the initial work. These changes have landed as part of #824.

@carllerche carllerche closed this Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.