Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upbump slab to 0.4 #768
Conversation
ignatenkobrain
force-pushed the
ignatenkobrain:patch-2
branch
from
97dbf49
to
c0c78ce
Dec 1, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. It doesn't look like CI is happy with it. However, since slab is only used in deprecated code (I think), maybe it isn't worth trying to update the crate? |
This comment has been minimized.
This comment has been minimized.
|
Okay, seems that many crates depend on slab 0.3, so I will create additionalversion of that in Fedora. |
ignatenkobrain
closed this
Dec 3, 2017
This comment has been minimized.
This comment has been minimized.
|
But it would be still nice to update it, because tokio-core requires slab0.4 and mio which requires slab0.3.. |
ignatenkobrain
reopened this
Jan 10, 2018
ignatenkobrain
force-pushed the
ignatenkobrain:patch-2
branch
from
c0c78ce
to
e327ff6
Jan 10, 2018
This comment has been minimized.
This comment has been minimized.
|
@carllerche so the new version of mio didn't remove dependency and it is blocking me from packaging mio in Fedora... So I spent some time and ported it.. Please review this PR ;) |
carllerche
requested changes
Jan 26, 2018
|
I only did a quick skim, but it seemed at a glance that the change is more extensive than I think it should be. At the very least, it looks like it is removing public types, which cannot be done in patch releases. I would ask that all public types stay and the diff be reduced to the minimum necessary to bump the version. |
|
|
||
|
|
||
| #[derive(Debug)] | ||
| pub struct TimerError { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ignatenkobrain Any chance that you could update this? If not, do you mind if I take it over? |
briansmith
referenced this pull request
Mar 2, 2018
Merged
Update slab dependency from 0.3 to 0.4 #824
This comment has been minimized.
This comment has been minimized.
|
Thanks for the initial work. These changes have landed as part of #824. |
ignatenkobrain commentedDec 1, 2017
No description provided.