Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upadd TcpStream::peek #773
Conversation
src/sys/windows/tcp.rs
Outdated
| pub fn peek(&self, buf: &mut [u8]) -> io::Result<usize> { | ||
| let mut me = self.inner(); | ||
|
|
||
| match me.read { |
This comment has been minimized.
This comment has been minimized.
carllerche
Dec 13, 2017
Owner
It looks like this block is copied verbatim from readv? Would you mind extracting this to a before_read fn or something like that?
This comment has been minimized.
This comment has been minimized.
carllerche
approved these changes
Dec 13, 2017
seanmonstar
force-pushed the
seanmonstar:peek
branch
from
044a505
to
9175b83
Dec 13, 2017
This comment has been minimized.
This comment has been minimized.
|
Ah, so this requires a newer version of Rust than what is being tested on Travis. Breaking change needing 0.7, or just Deal With It? |
seanmonstar
added some commits
Dec 13, 2017
seanmonstar
force-pushed the
seanmonstar:peek
branch
from
9175b83
to
b5ac91d
Dec 13, 2017
This comment has been minimized.
This comment has been minimized.
|
CI passed! |
carllerche
merged commit ed3d66a
into
carllerche:master
Dec 14, 2017
jacobmorzinski
referenced this pull request
Jan 9, 2018
Closed
Windows compilation error: use of unstable library feature 'peek' #26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
seanmonstar commentedDec 13, 2017
No description provided.