New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lio_listio(2) support for DragonFly - Fix compile #805

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
3 participants
@mneumann
Copy link
Contributor

mneumann commented Jan 11, 2018

There is no EVFILT_LIO on DragonFly. Commit 00d8573 failed to
compile on DragonFly. There seems to be no (official) LIO support,
at least it is not mentioned anywhere in manpages etc.

With this commit, mio can be build again on DragonFly and all tests pass.

mneumann referenced this pull request Jan 11, 2018

lio_listio(2) support (#780)
On FreeBSD and DragonflyBSD, kevent(2) has a distinct filter type for
use with lio_listio(2).  This commit adds 2 new public methods:
UnixReady::lio and UnixReady::is_lio.

This patch also deprecates AIO fns on platforms that do not
support AIO.
@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Jan 11, 2018

Is there a way to get DragonFly added to the CI run?

@asomers

This comment has been minimized.

Copy link
Collaborator

asomers commented Jan 11, 2018

Not easiliy. Neither rustup nor japaric/cross support Dragonfly. I suppose that means that for Dragonfly, the toolchain is build from ports? Adding Dragonfly to CI would require creating a buildbot/jenkins instance, and it may not be possible to always use the same version of Rust for Dragonfly as for Travis.

@mneumann

This comment has been minimized.

Copy link
Contributor

mneumann commented Jan 16, 2018

Yes, rust on DragonFly is build from ports (we call them "dports"). There is a docker script in the rust repo which cross-compiles Rust for DragonFly on Linux, but due to missing compute resources it never got enabled. So there are no "official" builds for DragonFly (yet).

@mneumann

This comment has been minimized.

Copy link
Contributor

mneumann commented Jan 20, 2018

@carllerche: can we merge this, despite having no CI for DragonFly?

@carllerche

This comment has been minimized.

Copy link
Owner

carllerche commented Jan 23, 2018

Could you remove Dragonfly from the list of supported platforms?

Unfortunately, I can't really claim it is supported unless there is CI. I can merge the PR otherwise.

Remove lio_listio(2) support for DragonFly - Fix compile
There is no EVFILT_LIO on DragonFly. Commit 00d8573 failed to
compile on DragonFly. There seems to be no (official) LIO support,
at least it is not mentioned anywhere in manpages etc.

With this commit, mio can be build again on DragonFly and all tests pass.

@mneumann mneumann force-pushed the mneumann:fix-dragonfly-lio branch from 417e286 to 4eec1fe Jan 23, 2018

@mneumann

This comment has been minimized.

Copy link
Contributor

mneumann commented Jan 23, 2018

@carllerche removed DragonFly from the list and "merged" the two commits into one.

@carllerche carllerche merged commit 726b1f3 into carllerche:master Jan 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mneumann mneumann deleted the mneumann:fix-dragonfly-lio branch Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment