Attributes

[dtolnay]

Fixes #56.

impl_web! {
    impl JsonResource {
        #[get("/")]
        fn hello_world(&self) -> Result<serde_json::Value, ()> {
            Ok(json!({ "message": "hello world" }))
        }
    }
}

[carllerche]

Nice... looking through the PR, the trade off would be that #![recursion_limit = "N"] would be required by users?

[dtolnay]

Yes -- this approach scans the tokens inside the impl block one at a time looking for tower-web attributes. There are ways to process multiple tokens per level of macro recursion to reduce the recursion depth. I pushed a commit to illustrate.

[carllerche]

cc @shepmaster

[shepmaster]

I always find myself (irrationally) annoyed at having to add #![recursion_limit="128"], but it is nice that when the "real" support is added that attribute can just be removed.

Converting my code to the attributes seemed straight-forward and things seemingly continue to work. Overall, I'm happy with the end result as an end-user.

[carllerche]

👍