From 7861476d4f18753879f70cf0def8515dff67187c Mon Sep 17 00:00:00 2001 From: Joshua Young Date: Sun, 21 Apr 2024 20:30:55 +1000 Subject: [PATCH] Encourage `#lease_connection` over `#connection` on AR model `#inspect` without connection --- activerecord/lib/active_record/core.rb | 2 +- activerecord/test/cases/invalid_connection_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb index e54735ba513ec..23502fcf29829 100644 --- a/activerecord/lib/active_record/core.rb +++ b/activerecord/lib/active_record/core.rb @@ -354,7 +354,7 @@ def inspect # :nodoc: elsif abstract_class? "#{super}(abstract)" elsif !connected? - "#{super} (call '#{super}.connection' to establish a connection)" + "#{super} (call '#{super}.lease_connection' to establish a connection)" elsif table_exists? attr_list = attribute_types.map { |name, type| "#{name}: #{type.type}" } * ", " "#{super}(#{attr_list})" diff --git a/activerecord/test/cases/invalid_connection_test.rb b/activerecord/test/cases/invalid_connection_test.rb index 747eb02950004..7819682b0ee09 100644 --- a/activerecord/test/cases/invalid_connection_test.rb +++ b/activerecord/test/cases/invalid_connection_test.rb @@ -20,7 +20,7 @@ def setup end test "inspect on Model class does not raise" do - assert_equal "#{Bird.name} (call '#{Bird.name}.connection' to establish a connection)", Bird.inspect + assert_equal "#{Bird.name} (call '#{Bird.name}.lease_connection' to establish a connection)", Bird.inspect end end end