Permalink
Commits on Feb 27, 2017
  1. Merge pull request #28160 from y-yagi/only_load_systemtestcase_if_pum…

    …a_is_defined
    
    Only load SystemTestCase if Puma is defined
    eileencodes committed on GitHub Feb 27, 2017
Commits on Feb 26, 2017
  1. Only load SystemTestCase if Puma is defined

    SystemTestCase supports only Puma, and always load puma's file.
    https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/system_testing/server.rb#L1
    
    For that reason, the case of use Capybara but do not use Puma, it will cause an error.
    So we need to check about Puma is defined as well.
    y-yagi committed Feb 25, 2017
  2. Merge pull request #28188 from kamipo/use_max_identifier_length_for_i…

    …ndex_name_length
    
    Use `max_identifier_length` for `index_name_length`
    pixeltrix committed on GitHub Feb 26, 2017
  3. Merge pull request #28187 from kamipo/fix_intermittent_test_failure

    Fix `test_apply_distinct_in_count` failure in PG adapter
    pixeltrix committed on GitHub Feb 26, 2017
  4. Merge pull request #25274 from kamipo/fix_find_nth_with_limit_value

    Fix `find_nth` with `limit_value`
    pixeltrix committed on GitHub Feb 26, 2017
  5. Merge pull request #28190 from annejohnson/update-i18n-guide-with-zer…

    …o-opt
    
    Update i18n guide to cover :zero key support in pluralization [ci skip]
    maclover7 committed on GitHub Feb 26, 2017
  6. Fix `test_apply_distinct_in_count` failure in PG adapter

    ```
    % ARCONN=postgresql be ruby -w -Itest test/cases/calculations_test.rb -n test_apply_distinct_in_count
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/enumerable.rb:20: warning: method redefined; discarding old sum
    Using postgresql
    Run options: -n test_apply_distinct_in_count --seed 27731
    
    F
    
    Finished in 0.163682s, 6.1094 runs/s, 30.5470 assertions/s.
    
      1) Failure:
    CalculationsTest#test_apply_distinct_in_count [test/cases/calculations_test.rb:238]:
    Expected /\ASELECT(?! DISTINCT) COUNT\(DISTINCT\b/ to match "SHOW max_identifier_length".
    
    1 runs, 5 assertions, 1 failures, 0 errors, 0 skips
    ```
    
    https://travis-ci.org/rails/rails/jobs/205493811#L1933
    https://travis-ci.org/rails/rails/jobs/205496299#L1562
    https://travis-ci.org/rails/rails/jobs/205514765#L1562
    kamipo committed Feb 26, 2017
  7. Use `max_identifier_length` for `index_name_length` in PostgreSQL ada…

    …pter
    
    Actually `index_name_length` depend on `max_identifier_length`, not
    always 63.
    kamipo committed Feb 26, 2017
  8. Merge pull request #28172 from kamipo/deprecate_supports_migrations

    Deprecate `supports_migrations?` on connection adapters
    pixeltrix committed on GitHub Feb 26, 2017
  9. Merge pull request #28186 from kirs/patch-2

    Refactor connection_pool_test
    pixeltrix committed on GitHub Feb 26, 2017
  10. Deprecate `supports_migrations?` on connection adapters

    `supports_migrations?` was added at 4160b51 to determine if schema
    statements (`create_table`, `drop_table`, etc) are implemented in the
    adapter. But all tested databases has been supported migrations since
    a4fc93c at least.
    kamipo committed Feb 25, 2017
  11. Refactor connection_pool_test

    kirs committed with kirs Feb 26, 2017
  12. Merge pull request #28183 from eugeneius/having_select_column

    Include selects in group query with having clause
    pixeltrix committed on GitHub Feb 26, 2017
  13. Include selects in group query with having clause

    When a grouped calculation contains a having clause that references a
    selected value, we need to include that selected value in the query.
    
    Postgres doesn't support referencing a selected value in a having
    clause, but other databases do; we can skip the test on the pg adapter
    but run it for the others.
    
    This was fixed before in 9a298a1, but
    the test coverage was lost in 5a05207.
    The fix regressed in 6311975 and was
    removed in 97d46c1.
    eugeneius committed Feb 26, 2017
  14. Merge pull request #28106 from jerry-tao/master

    Remove unused params in RouteSet#add_route
    pixeltrix committed Feb 26, 2017
  15. Remove unused params.

    Jerry Tao committed with pixeltrix Feb 22, 2017
  16. Fix `find_nth` with `limit_value`

    If the `index` exceeds a `limit`, simply return an empty result without
    querying the database.
    kamipo committed Jun 4, 2016
  17. Merge pull request #28176 from kamipo/push_valid_type_up_to_abstract_…

    …adapter
    
    Push `valid_type?` up to abstract adapter
    pixeltrix committed on GitHub Feb 26, 2017
  18. Merge pull request #28177 from kami-zh/remove-duplicated-private

    Remove duplicated private method in ActiveRecord::FinderMethods
    pixeltrix committed on GitHub Feb 26, 2017
  19. Merge pull request #28179 from kamipo/remove_useless_line

    Remove useless `select_values += select_values`
    pixeltrix committed on GitHub Feb 26, 2017
  20. Merge pull request #28180 from y-yagi/use_released_arel

    Use released arel
    pixeltrix committed on GitHub Feb 26, 2017
  21. Use released arel

    Follow up to ea9566f
    y-yagi committed Feb 26, 2017
  22. Remove useless `select_values += select_values`

    `select_values` is a local variable defined at previous line.
    `select_values += select_values` is totally useless.
    kamipo committed Feb 26, 2017
  23. Remove duplicated private method

    kami-zh committed Feb 26, 2017
  24. Add Duration#before and #after as aliases for #ago and #since

    It's common in test cases at my job to have code like this:
    
        let(:today) { customer_start_date + 2.weeks }
        let(:earlier_date) { today - 5.days }
    
    With this change, we can instead write
    
        let(:today) { 2.weeks.after(customer_start_date) }
        let(:earlier_date) { 5.days.before(today) }
    
    Closes #27721
    Widdershin committed with jeremy Feb 22, 2017
  25. Push `valid_type?` up to abstract adapter

    `valid_type?` should return true if a type exists in
    `native_database_types` at least.
    
    https://github.com/rails/rails/blob/v5.1.0.beta1/activerecord/lib/active_record/schema_dumper.rb#L136
    kamipo committed Feb 26, 2017
  26. Merge pull request #28175 from sevenseacat/patch-1

    Fix typo 'affect' -> 'effect' [ci skip]
    kaspth committed on GitHub Feb 26, 2017
  27. Fix typo 'affect' -> 'effect' [ci skip]

    sevenseacat committed on GitHub Feb 26, 2017
  28. Fix `change_column` to drop default with `null: false`

    Currently `change_column` cannot drop default if `null: false` is
    specified at the same time. This change fixes the issue.
    
    ```ruby
      # cannot drop default
      change_column "tests", "contributor", :boolean, default: nil, null: false
    
      # we need the following workaround currently
      change_column "tests", "contributor", :boolean, null: false
      change_column "tests", "contributor", :boolean, default: nil
    ```
    
    Closes #26582
    kamipo committed with jeremy Sep 22, 2016
  29. Merge pull request #28173 from vipulnsward/as-ch-pass

    AS CHANGELOG Pass
    kaspth committed on GitHub Feb 26, 2017
  30. AS CHANGELOG Pass [ci skip]

    vipulnsward committed Feb 26, 2017
  31. Merge pull request #28167 from kirs/deprecate-verify-args

    Deprecate AbstractAdapter#verify! with arguments
    matthewd committed on GitHub Feb 26, 2017
  32. Merge pull request #28169 from kirs/ensure-conn-verify

    Use ensure block for things we cleanup in tests
    matthewd committed on GitHub Feb 26, 2017