Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove platform specific gitmojis #471

Merged
merged 4 commits into from Jun 26, 2020

Conversation

johannchopin
Copy link
Collaborator

Description

Closes #452

Tests

  • All tests passed.

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@johannchopin
Copy link
Collaborator Author

@vhoyer, @carloscuesta Travis still expect a Branch check as you can see above:

Travis CI - Branch Expected — Waiting for status to be reported

Can't figure out what is going on since Travis builded my fork successfully as you can see here.

@vhoyer
Copy link
Collaborator

vhoyer commented Jun 25, 2020

this happened to me before on another repo, the travis is not running beause it don't have access to your repo, since your branch is in another repo. So we can't have this check 😅,

Or at least I think that is

@carloscuesta
Copy link
Owner

I'm going to fix that check

@carloscuesta carloscuesta merged commit 7f4c673 into carloscuesta:master Jun 26, 2020
benavern pushed a commit to benavern/gitmoji that referenced this pull request Aug 25, 2020
* 🔥  Remove platform specific gitmojis
* 💄  Remove unused scss gitmoji colors
* 📸  pages
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should gitmoji be platform agnostic?
3 participants