Carlos Eduardo L. Lopes carloslopes

Organizations

@GuruCampinas @Codeminer42 @bootstrap-ruby
carloslopes closed pull request ankane/searchkick#122
@carloslopes
Add support for has_child / has_parent filter
carloslopes commented on pull request ankane/searchkick#122
@carloslopes

I'm closing this PR for two reasons. It was made using the old searchkick structure, and now everything is different inside it; The change made he…

@carloslopes

You separated the form string in multiple pieces, but we are not using this approach. It's bikeshedding, but it would be great to keep the suite co…

@carloslopes

Thanks @ChouAndy I just made a comment there

@carloslopes

I think this test should not be inside this file, because it's not related to only checkboxes. Maybe bootstrap_form_test.rb would be a better place

@carloslopes

You're welcome!

@carloslopes
I expect the i18n placeholder translations to work
@carloslopes

@kieranklaassen afaik the helpers namespace is not used on active record translations. Take a look at this guide, it can help you http://guides.rub…

@carloslopes
Question: Is there a way to generate form fields without a <form> ?
@carloslopes

Sorry bur this is currently not possible. Maybe when we add global configs support (#43) we can work on this. If you have any other issue, just ask!

@carloslopes

Sorry again for the daly guys! :cry: Now the correction is on master. Thank you so much for the feedback

@carloslopes
@carloslopes
offset of checkbox in horizontal form not correctly inferred
@carloslopes
generate_help reuses the existing get_error_messages method
3 commits with 14 additions and 3 deletions
@carloslopes

Thanks! :heart:

@carloslopes

Hey @ChouAndy, Thank you so much for this! Can you please open a PR and add tests for this change?

@carloslopes

Hi @kntmrkm, IMHO if we follow the paths that you said, we will not solve the real issue. Because your page will continue to have multiple elements…

@carloslopes

Hey @aditya01933, Probably what is going on is that Password is the label and the sentence is the help text. So, they are rendered separately. But,…

@carloslopes

Thanks for the PR @raptblue! I just made some comments, can you take a look at them?

@carloslopes

If you break the iteration after the first positive match of btn-lg, you will not need this unless

@carloslopes

You can avoid this conditional if you send #compact! on the array before start the iteration