Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use `count(*)` instead of `select * from table`; #309

Merged
merged 1 commit into from Oct 8, 2015

Conversation

@yrik
Copy link
Contributor

commented Oct 7, 2015

No description provided.

@carltongibson

This comment has been minimized.

Copy link
Owner

commented Oct 8, 2015

OK. This seems reasonable.

Can I just ask, how come you found it? Just browsing the source or was there an issue?

@yrik

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2015

It was easy to notice on 3M database when page crashed with 504 error. Had to patch django to log queries before execution. Found that it was caused by this query.

@carltongibson

This comment has been minimized.

Copy link
Owner

commented Oct 8, 2015

Nice. 😀

We'll have this then.

I'm prepping a new release. It won't be for a bit though (i.e. I hope next week but it's possible it could slip), so you may want to deploy off of develop in the meantime.

carltongibson pushed a commit that referenced this pull request Oct 8, 2015

Carlton Gibson
Merge pull request #309 from yrik/patch-2
use `count(*)` instead of `select * from table`;

@carltongibson carltongibson merged commit adb68f7 into carltongibson:develop Oct 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@yrik

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2015

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.