Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use urlencode from django.utils.http #760

Merged
merged 1 commit into from Aug 22, 2017

Conversation

tony
Copy link
Contributor

@tony tony commented Aug 22, 2017

This works across django versions from at least version 1.7 and is
compatible across python versions.

https://docs.djangoproject.com/en/1.8/ref/utils/#django.utils.http.urlencode

This works across django versions from at least version 1.7 and is
compatible across python versions.

https://docs.djangoproject.com/en/1.8/ref/utils/#django.utils.http.urlencode
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 22, 2017

Codecov Report

Merging #760 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #760      +/-   ##
===========================================
- Coverage    98.13%   98.13%   -0.01%     
===========================================
  Files           15       15              
  Lines         1126     1123       -3     
===========================================
- Hits          1105     1102       -3     
  Misses          21       21
Impacted Files Coverage Δ
django_filters/widgets.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22682ee...c5bd030. Read the comment docs.

Copy link
Owner

@carltongibson carltongibson left a comment

Yep. Great. Thanks!

@carltongibson carltongibson merged commit 0112ff5 into carltongibson:develop Aug 22, 2017
1 check passed
@tony tony deleted the urllib branch Aug 22, 2017
carltongibson pushed a commit that referenced this issue Oct 19, 2017
This works across django versions from at least version 1.7 and is
compatible across python versions.

https://docs.djangoproject.com/en/1.8/ref/utils/#django.utils.http.urlencode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants