Carlton Gibson carltongibson

@carltongibson
@carltongibson
Adds a third option for strict to raise a Validation Error
7 commits with 33 additions and 14 deletions
carltongibson commented on pull request alex/django-filter#136
@carltongibson

@wolfe, @mdentremont — Thanks for this gentlemen. Very good.

@carltongibson
@carltongibson
Edit for clarity in filters.txt
1 commit with 8 additions and 3 deletions
carltongibson commented on pull request alex/django-filter#257
@carltongibson

👍

@carltongibson
@carltongibson
Update filters.txt
1 commit with 10 additions and 1 deletion
carltongibson commented on pull request alex/django-filter#251
@carltongibson

👍

carltongibson commented on pull request alex/django-filter#259
@carltongibson

First pass I'd guess sublclass TextInput and just do the join on the value. The ‘value’ given is not guaranteed to be valid input, therefore subc…

carltongibson commented on pull request alex/django-filter#259
@carltongibson

Hi @zoidbergwill. Thanks for the PR. My initial thought is that this needs to be done at the widget level rather than the filter. Look at the Selec…

@carltongibson
@carltongibson
Retrieve objects by hyperlink (HyperlinkModelSerializer)
@carltongibson

Hi @Mostey First off: ideally you'd use the Mailing List for usage questions and discussions. However... If you send a list of the full hyperlink…

@carltongibson

@tiagoboldt Are you talking about the Or filtering or the 1,2,3 syntax? The Or filtering works — this ticket is only still open because I haven't …

carltongibson commented on pull request alex/django-filter#136
@carltongibson

Good work both of you! I'll review and merge. Thanks!

@carltongibson

Glad you fixed it. 👍

@carltongibson

Hey @zoidbergwill — No problem — and "Not exactly". The are two options if you want to support the 1,2,3 syntax — a custom filter(as per the examp…

@carltongibson
@carltongibson
Minor correction to usage docs
1 commit with 2 additions and 2 deletions
carltongibson commented on pull request alex/django-filter#255
@carltongibson

Brilliant. Thanks. 👍

@carltongibson

Yeah perhaps you're right. My concern is that most of it isn't really about PRs. @cancan101 is active and that's going to add more than my being A…

@carltongibson

Hey @cancan101. I think you have the makings of a great maintainer for DRF: you've been around for a good while, you're active and you use it daily…

@carltongibson

Ah. Perhaps not by ID then... but if you can't fetch them, then you can't do it by hand.

@carltongibson

Presumably you know the IDs of the new objects. You can fetch those and call the signal by hand... ... post_save.send(MyModel, instance=instance, c…

@carltongibson

If you can provide a falling test-case showing your problem that would help.

@carltongibson

@sodastsai Yes. The tests pass. Playing with it locally, nothing seems broken — but I'm not using Jinja. If nobody has any qualms I'd say merge it …

@carltongibson

Awesome! @diox please close