rails4 compatibility #20

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
@grncdr

grncdr commented Feb 9, 2013

Hey, this isn't backwards compatible with rails3, but was necessary to get the form_helper to work with rails4.

@Nowaker

This comment has been minimized.

Show comment Hide comment
@Nowaker

Nowaker Mar 17, 2013

Is there any reason why it's still not merged? Is the gem maintained?

Using this for now:

gem 'carmen-rails', :git => 'https://github.com/freerunningtechnologies/carmen-rails', :branch => 'rails4'

Nowaker commented Mar 17, 2013

Is there any reason why it's still not merged? Is the gem maintained?

Using this for now:

gem 'carmen-rails', :git => 'https://github.com/freerunningtechnologies/carmen-rails', :branch => 'rails4'

cbrunsdon and others added some commits Mar 20, 2013

move prompt above priority options
Change-Id: I33f72753105fa45af43cba78eb57e9b35912aabd
Adam Mueller
Add to_s to Rails.version
Due to rails/rails#8501.

Change-Id: I3a5580e12a9f4bc013bb98db9aa6d8c3e11bf0c5
@tamird

This comment has been minimized.

Show comment Hide comment
@tamird

tamird Mar 26, 2013

Nitpicking a bit, but this is not the right way to do it.

2.0.0p0 :020 > '4.0.0.beta1' > '4.0.0.1'
 => true
2.0.0p0 :021 > Gem::Version.new('4.0.0.beta1') > Gem::Version.new('4.0.0.1')
 => false

String comparison semantics are different from Gem::Version comparison semantics.

tamird commented on 92d6d10 Mar 26, 2013

Nitpicking a bit, but this is not the right way to do it.

2.0.0p0 :020 > '4.0.0.beta1' > '4.0.0.1'
 => true
2.0.0p0 :021 > Gem::Version.new('4.0.0.beta1') > Gem::Version.new('4.0.0.1')
 => false

String comparison semantics are different from Gem::Version comparison semantics.

@dainmiller

This comment has been minimized.

Show comment Hide comment
@dainmiller

dainmiller Apr 10, 2013

Collaborator

This gem is still being maintained but is possibly switching owners. Thanks for these pull requests though guys and this is one of the high priority things to review when we are done with the process for carmen-rails migration.

Collaborator

dainmiller commented Apr 10, 2013

This gem is still being maintained but is possibly switching owners. Thanks for these pull requests though guys and this is one of the high priority things to review when we are done with the process for carmen-rails migration.

@bcm

This comment has been minimized.

Show comment Hide comment
@bcm

bcm Jul 17, 2013

any updates? now that rails 4 is released it would be nice to get a compatible version of carmen released.

bcm commented Jul 17, 2013

any updates? now that rails 4 is released it would be nice to get a compatible version of carmen released.

@bcm

This comment has been minimized.

Show comment Hide comment
@bcm

bcm Aug 13, 2013

ping!

bcm commented Aug 13, 2013

ping!

@paulkoegel

This comment has been minimized.

Show comment Hide comment
@paulkoegel

paulkoegel Sep 12, 2013

any update? carmen-rails is unusable for me right now =(

any update? carmen-rails is unusable for me right now =(

@brumm

This comment has been minimized.

Show comment Hide comment
@brumm

brumm Sep 12, 2013

👍

brumm commented Sep 12, 2013

👍

@bcm

This comment has been minimized.

Show comment Hide comment
@bcm

bcm Sep 12, 2013

looks like this got merged instead: 38ea9c0

I guess @jim wasn't aware we were all watching this issue :)

bcm commented Sep 12, 2013

looks like this got merged instead: 38ea9c0

I guess @jim wasn't aware we were all watching this issue :)

@pablocrivella

This comment has been minimized.

Show comment Hide comment
@pablocrivella

pablocrivella Feb 28, 2014

is this gem still unusable on rails 4? does anyone know any alternatives?

is this gem still unusable on rails 4? does anyone know any alternatives?

@Nowaker

This comment has been minimized.

Show comment Hide comment
@Nowaker

This comment has been minimized.

Show comment Hide comment
@Nowaker

Nowaker Feb 28, 2014

@freerunningtech Would you mind releasing your https://github.com/freerunningtechnologies/carmen-rails rails4 branch as a gem, e.g. carmen-rails4? The author doesn't care about this gem so you are our last hope.

Nowaker commented Feb 28, 2014

@freerunningtech Would you mind releasing your https://github.com/freerunningtechnologies/carmen-rails rails4 branch as a gem, e.g. carmen-rails4? The author doesn't care about this gem so you are our last hope.

@jim

This comment has been minimized.

Show comment Hide comment
@jim

jim Feb 28, 2014

Collaborator

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.

Collaborator

jim commented Feb 28, 2014

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.

@bcm

This comment has been minimized.

Show comment Hide comment
@bcm

bcm Feb 28, 2014

38ea9c0 appears to have made the gem rails 4 compatible. looks like somebody just needs to push a new version of the gem.

bcm commented Feb 28, 2014

38ea9c0 appears to have made the gem rails 4 compatible. looks like somebody just needs to push a new version of the gem.

@dainmiller

This comment has been minimized.

Show comment Hide comment
@dainmiller

dainmiller Feb 28, 2014

Collaborator

Sorry guys, been so busy. We could definitely use some help maintaining this.

Collaborator

dainmiller commented Feb 28, 2014

Sorry guys, been so busy. We could definitely use some help maintaining this.

@Nowaker

This comment has been minimized.

Show comment Hide comment
@Nowaker

Nowaker Feb 28, 2014

@jim, the gem from the repo I mentioned, branch rails4, is fully working. Just merge it and you are done.

Kind regards
Damian Nowak

-----Original Message-----
From: Jim Benton notifications@github.com
To: jim/carmen-rails carmen-rails@noreply.github.com
Cc: Damian Nowak spam@nowaker.net
Sent: Fri, 28 Feb 2014 20:31
Subject: Re: [carmen-rails] rails4 compatibility (#20)

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.


Reply to this email directly or view it on GitHub:
jim#20 (comment)

Nowaker commented Feb 28, 2014

@jim, the gem from the repo I mentioned, branch rails4, is fully working. Just merge it and you are done.

Kind regards
Damian Nowak

-----Original Message-----
From: Jim Benton notifications@github.com
To: jim/carmen-rails carmen-rails@noreply.github.com
Cc: Damian Nowak spam@nowaker.net
Sent: Fri, 28 Feb 2014 20:31
Subject: Re: [carmen-rails] rails4 compatibility (#20)

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.


Reply to this email directly or view it on GitHub:
jim#20 (comment)

@jim

This comment has been minimized.

Show comment Hide comment
@jim

jim Mar 6, 2014

Collaborator

@Nowaker That branch doesn't merge cleanly into master, and when I resolve the conflicts, it still has failing tests.

I've just released 1.0.1. Can anyone running into a problem with Rails 4 give it a go and see if it resolves your issues?

Collaborator

jim commented Mar 6, 2014

@Nowaker That branch doesn't merge cleanly into master, and when I resolve the conflicts, it still has failing tests.

I've just released 1.0.1. Can anyone running into a problem with Rails 4 give it a go and see if it resolves your issues?

@alanheppenstall

This comment has been minimized.

Show comment Hide comment
@alanheppenstall

alanheppenstall Mar 7, 2014

@jim It works great for me in 4.0.0 and in 4.0.3 in a modified version of your example app (https://github.com/alanheppenstall/carmen-rails-example-rails4test)

@jim It works great for me in 4.0.0 and in 4.0.3 in a modified version of your example app (https://github.com/alanheppenstall/carmen-rails-example-rails4test)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment