Resolves subregion error when including additional data paths #130

Merged
merged 1 commit into from Mar 1, 2014

Conversation

Projects
None yet
2 participants
@seangaffney
Contributor

seangaffney commented Nov 1, 2013

This addresses an error with subregions when adding another data_path to Carmen. The library expected there to be subregion files in the added data_path for all of the regions specified in the gem's included world.yml file, and thusly would throw an error when trying to load data from the non-existent YAML files, not allowing you to even access existing subregions.

I believe the specs are reasonable, but if you have any questions or suggestions just let me know. :)

@seangaffney

This comment has been minimized.

Show comment Hide comment
@seangaffney

seangaffney Nov 1, 2013

Contributor

Aaaaand just realized that #129 already addresses this issue, although I think my tests are more thorough. 😉

Contributor

seangaffney commented Nov 1, 2013

Aaaaand just realized that #129 already addresses this issue, although I think my tests are more thorough. 😉

@jim

This comment has been minimized.

Show comment Hide comment
@jim

jim Mar 1, 2014

Collaborator

Thanks for the patch. I will look at this soon.

Collaborator

jim commented Mar 1, 2014

Thanks for the patch. I will look at this soon.

jim added a commit that referenced this pull request Mar 1, 2014

Merge pull request #130 from seangaffney/master
Resolves subregion error when including additional data paths

@jim jim merged commit 8191406 into carmen-ruby:master Mar 1, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment