Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Resolves subregion error when including additional data paths #130
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
seangaffney
Nov 1, 2013
Contributor
Aaaaand just realized that #129 already addresses this issue, although I think my tests are more thorough.
|
Aaaaand just realized that #129 already addresses this issue, although I think my tests are more thorough. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks for the patch. I will look at this soon. |
added a commit
that referenced
this pull request
Mar 1, 2014
jim
merged commit 8191406
into
carmen-ruby:master
Mar 1, 2014
1 check passed
default
The Travis CI build passed
Details
jim
referenced this pull request
Mar 1, 2014
Closed
fix for issues 114 and 118: appended data paths for new regions #129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
seangaffney commentedNov 1, 2013
This addresses an error with subregions when adding another
data_pathto Carmen. The library expected there to be subregion files in the addeddata_pathfor all of the regions specified in the gem's includedworld.ymlfile, and thusly would throw an error when trying to load data from the non-existent YAML files, not allowing you to even access existing subregions.I believe the specs are reasonable, but if you have any questions or suggestions just let me know. :)