Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network usage is prohibited for themes #39

Closed
joethei opened this issue Nov 20, 2023 · 2 comments · Fixed by #40
Closed

Network usage is prohibited for themes #39

joethei opened this issue Nov 20, 2023 · 2 comments · Fixed by #40
Labels
enhancement New feature or request

Comments

@joethei
Copy link

joethei commented Nov 20, 2023

It appears that your theme uses network connections to load assets (e.g. fonts, icons, or images). This is prohibited by the official Obsidian developer policies because themes should function completely locally.

You can bundle an asset for local use by using data URLs. See this guide.

Please let us know if you have any questions. Any themes that use network connections will be removed from the official directory in the first week of January 2024.

  • The Obsidian team.
@joethei joethei added the bug Something isn't working label Nov 20, 2023
@caro401
Copy link
Owner

caro401 commented Nov 20, 2023

@LEFD what do you think is the best path forward for this?

Possibly the best thing is just not bundling the font anymore, so people can opt into using the fonts I like, but that's a breaking change. I'm not sure the best way to communicate to people that they would need to install fonts to keep the theme looking the same

@caro401 caro401 added enhancement New feature or request and removed bug Something isn't working labels Nov 20, 2023
@LEFD
Copy link
Collaborator

LEFD commented Nov 20, 2023

@caro401 I think the best way forward would be to embed the fonts in the CSS file. That's a bit messy, but this way the theme would look as we intended out of the box.

I'm not sure the best way to communicate to people that they would need to install fonts to keep the theme looking the same

I don't think people read change logs for themes. (I don't). Installing fonts on mobile devices might be a problem as well.
Also, one always has the option to use a custom font if one desires to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants