Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unicode Support #20

Closed
caronc opened this issue Sep 26, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@caronc
Copy link
Owner

commented Sep 26, 2018

Here is the original traceback source before it was tidied up below:

Traceback (most recent call last):
...
File "apprise\Apprise.py", line 248, in notify
File "path\to\markdown\__init__.py", line 470, in markdown
File "path\to\markdown\__init__.py", line 338, in convert
UnicodeDecodeError: 'ascii' codec can't decode byte 0x92 in position 3078: ordinal not in range(128). -- Note: Markdown only accepts unicode input!

Apprise should operate similar to markdown and convert everything to unicode prior to working with the string. This will fix compatibility with markdown and fix any other compatibility issues down the road as well.

@caronc caronc self-assigned this Sep 26, 2018

@caronc caronc added the bug label Sep 26, 2018

@caronc

This comment has been minimized.

Copy link
Owner Author

commented Jan 27, 2019

Will close this ticket as i decided this shouldn't be solved in apprise. Just as markdown expects the developer to convert everything ahead of time to unicode safe format, apprise should operate the same way and expect the same.

The bug originates from nzb-notifiy, so that is where it should be resolved. A ticket has already been open here.

@caronc caronc closed this Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.