Fix Zulip 401 when bot name contains a dash #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sending a message to Zulip failed with my setup:
The error is caused because the regex used to parse the bot name only considered the part before the first dash leading to an invalid user name being sent in the request's basic auth.
This pull request fixes the issue by making the bot name regex more permissive and manually stripping off the
-bot
suffix instead of doing it in the regex.Checklist
flake8
)