Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for lesson publication consent #1508

Open
fmichonneau opened this issue Jun 19, 2019 · 3 comments

Comments

@fmichonneau
Copy link
Member

commented Jun 19, 2019

Currently, the default value for the lesson publication consent is "No" making it impossible to distinguish between people who have not set the option yet, and people who have explicitly set it to "No".

  • is there something we can currently do to try to distinguish between these 2 situations?
  • could we add another option (e.g., "not set") that would become the default?

Thank you for submitting this issue to AMY. If this represents an urgent problem such as AMY not loading at all, please contact team@carpentries.org so we can respond promptly.

Non-urgent issues will be reviewed weekly by @maneesha. She will follow up here with you and/or other team members if more information is needed. Issues will be prioritized, considering whether they identify broken features, identify potential enhancements to existing features, or request implemention of entirely new features.

After prioritizing, one of the following will happen:

  • High priority issues will be included in an upcoming work cycle and labeled for an existing milestone.
  • Medium to low priority issues will be considered for a future work cycle and labeled "later." These will be re-reviewed periodically to consider them for an upcoming work cycle.
  • Issues that are stale, redundant, or are otherwise assessed not to positively impact user workflows will be closed and labeled "wont-fix"

Comments in the issue itself will provide further context. Please contact team@carpentries.org with any questions. Thank you again for your contribution and helping us improve AMY.

@maneesha

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

We could add an option for "unknown" and set that as default or make the default value be null. @pbanaszkiewicz What would make more sense to you?

@pbanaszkiewicz

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@maneesha I'll have to test which option is most suitable. Unfortunately I don't think there's a way to change "No" -> "Unknown" for people already in the database...

@fmichonneau

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

@pbanaszkiewicz it looks like the history of the edits made to a profile is stored in the database. Could we query the history to know if someone has edited their own profile since the option has been introduced? it wouldn't be perfect as some people might have not seen the option but it could be an appropriate approximation.

@pbanaszkiewicz pbanaszkiewicz self-assigned this Jul 1, 2019

@fmichonneau fmichonneau added this to the v2.9 milestone Jul 3, 2019

pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jul 7, 2019

Additional option for Lesson Publication Consent
This fixes carpentries#1508 by:
1) extending Lesson Publication Consent with one more option (undecided)
2) providing a migration that updates all persons, who have no record
   of being changed after first Lesson Publication Consent migration
   (0165) was introduced. This means they were neither logged in to
   change that option, nor changed by anyone else.

@pbanaszkiewicz pbanaszkiewicz referenced a pull request that will close this issue Jul 7, 2019

Open

Additional option for Lesson Publication Consent #1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.