Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "current"/ "unpublished" requirements #1516

Open
maneesha opened this issue Jul 10, 2019 · 9 comments
Open

Update "current"/ "unpublished" requirements #1516

maneesha opened this issue Jul 10, 2019 · 9 comments

Comments

@maneesha
Copy link
Contributor

@maneesha maneesha commented Jul 10, 2019

In addition to current requirements, a workshop should not show in the "Current" column in the AMY dashboard until at least one instructor has been assigned.

@maneesha maneesha added this to the v2.9 milestone Jul 10, 2019
@maneesha
Copy link
Contributor Author

@maneesha maneesha commented Jul 11, 2019

@pbanaszkiewicz says:

Extending the query should be easy once I know how to do it; unfortunately quering number of instructors is tricky, so I can't guarantee success here

We do have the number of instructors displayed in the "Unpublished" column of the dashboard. Would a different query be required to put this in the "Current" column?

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Jul 12, 2019

@maneesha:

We do have the number of instructors displayed in the "Unpublished" column of the dashboard. Would a different query be required to put this in the "Current" column?

I just looked in the code and the calculation of assigned instructors is done in one query. I think I can easily apply this to the "Current" workshops column.

@pbanaszkiewicz pbanaszkiewicz removed this from the v2.9 milestone Sep 15, 2019
@pbanaszkiewicz pbanaszkiewicz added this to the v2.10 milestone Sep 15, 2019
@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Jan 10, 2020

Okay, so I dug into this issue and have some follow-up questions.

@maneesha you're writing about "Current" column, but the issue's title mentions "Published requirements".

Should I change only the "Current" column?

We have a set of requirements used for selecting published events, and it's used for calculating "Current" column too. If I change conditions for published events, it will affect not only "Current", but also "Unpublished workshops" or API list of upcoming workshops (it was used by SWC/Carpentries website in past, not sure if it's still used).

@pbanaszkiewicz pbanaszkiewicz removed this from the v2.10 milestone Jan 12, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.11 milestone Jan 12, 2020
@pbanaszkiewicz pbanaszkiewicz removed this from the v2.11 milestone Feb 24, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.12 milestone Feb 24, 2020
@pbanaszkiewicz pbanaszkiewicz removed this from the v2.12 milestone May 2, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.13 milestone May 2, 2020
@pbanaszkiewicz pbanaszkiewicz removed this from the v2.13 milestone Jun 21, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.14 milestone Jun 21, 2020
@pbanaszkiewicz pbanaszkiewicz removed this from the v2.14 milestone Sep 2, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.15 milestone Sep 2, 2020
@maneesha
Copy link
Contributor Author

@maneesha maneesha commented Sep 29, 2020

As noted in #1716 the instructor count should include both Instructors and Supporting Instructors. If a workshop has ZERO instructors/supporting instructors, it should be in the "Unpublished" column. If it has at least one of either, it should be in the "Current" column.

We are no longer using the AMY API to publish workshops to our website, so that is not relevant.

Also changing title of this issue to be more accurate.

@maneesha maneesha changed the title Update "published" requirements Update "current"/ "unpublished" requirements Sep 29, 2020
@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Oct 16, 2020

Maybe disable API endpoints for published events while fixing the conditions @maneesha is asking for.

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Nov 11, 2020

@maneesha I need a little clarification.

Currently the workshop is considered unpublished when:

  1. it has no start date, OR
  2. it has no country, OR
  3. it has no venue, OR
  4. it has no address, OR
  5. it has no latitude, OR
  6. it has no longitude, OR
  7. it has no website URL.

Question: Do you want me to remove these conditions and replace them with a single: "has no instructors or supporting instructors"?

Workshops that have all required fields 1-7, are not cancelled, and

  • have a starting date in future OR
  • have starting date in past and ending date in future

are shown in "Current".

@maneesha
Copy link
Contributor Author

@maneesha maneesha commented Nov 13, 2020

We will check in on this at our team meeting next week and leave an update here.

@sheraaronhurt
Copy link

@sheraaronhurt sheraaronhurt commented Nov 23, 2020

Hey @pbanaszkiewicz I am going to be speaking with the RC's to see how they use the dashboard. I will report back in December. I meet with all of the RC's during the top of each month.

@pbanaszkiewicz pbanaszkiewicz removed this from the v2.15 milestone Dec 6, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.16 milestone Dec 6, 2020
@pbanaszkiewicz pbanaszkiewicz removed this from the v2.16 milestone Jan 28, 2021
@pbanaszkiewicz pbanaszkiewicz added this to the v2.17 milestone Jan 28, 2021
@pbanaszkiewicz pbanaszkiewicz removed this from the v3.0 milestone May 19, 2021
@maneesha
Copy link
Contributor Author

@maneesha maneesha commented Aug 10, 2021

Deferring this because we are talking with our team about changes to the dashboard and other views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants