Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification to admins when critical part of AMY is modified #1523

Open
fmichonneau opened this issue Aug 26, 2019 · 1 comment

Comments

@fmichonneau
Copy link
Member

commented Aug 26, 2019

[possibly related to #795]

To ensure that no critical component of AMY gets edited without it being noticed, having a notification system with email alerts sent to admins when something in the Django Admin panel is edited would be useful. This is probably going to be critical for the email templates once they are in place, but even for tags or other elements that can be edited, alerting others that it's taken place would make things safer.

@fmichonneau fmichonneau changed the title Notification to admins when critical part of is modified Notification to admins when critical part of AMY is modified Aug 26, 2019

@pbanaszkiewicz

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Just leaving some notes here:

  1. User actions in Django Admin are getting stored in LogEntry model provided by Django and are visible upon logging into Django Admin
    obraz

  2. We could perhaps reuse LogEntry to send notification when action occurs, but a more general way would be to react on signals sent out when crucial objects are being edited (e.g. Tags, Roles, Badges, EmailTemplates). Signals can be generated not only from the Django Admin actions, but also during normal using of AMY. Unfortunately they probably wouldn't prevent from the number of cases we had when a bug in Merging Events caused Tags to disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.