Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contact Field in AMY Events #1568

Closed
Talishask opened this issue Oct 30, 2019 · 4 comments · Fixed by #1642
Closed

Update Contact Field in AMY Events #1568

Talishask opened this issue Oct 30, 2019 · 4 comments · Fixed by #1642

Comments

@Talishask
Copy link

Currently the 'contact:' field in an AMY event lists information pulled from the workshop repo.

The field currently lists multiple email addresses as one continuous string rather than separating them with a delimiter or comma. For example, in this workshop: https://amy.carpentries.org/workshops/event/2019-10-24-gitbash/

With the update of the WRF to request additional contacts, we would like to update the contact field in the AMY event to:

  • List the emails from the 'Additional contacts:' field of the workshop request form [in place of the contacts from the workshop website]
  • Separate the email addresses with a comma

While this does not cause a work stoppage, it may be an important update to integrate into the typeform survey workflow.

@pbanaszkiewicz
Copy link
Contributor

Hello @Talishask. There are two things going on in here.


First:

The field currently lists multiple email addresses as one continuous string rather than separating them with a delimiter or comma. For example, in this workshop: https://amy.carpentries.org/workshops/event/2019-10-24-gitbash/

The reason for this is that the source website contains the email addresses joined: https://ucsbcarpentry.github.io/2019-10-24-gitbash/ (open source for this website in your browser, it's CTRL+U in Firefox on Windows), line 33:

    <meta name="contact" content="library-collaboratory@ucsb.edujonjab@ucsb.edu" />

So I assume the error is in workshop-template.


Second:

With the update of the WRF to request additional contacts, we would like to update the contact field in the AMY event [...]

Take a look at https://amy.carpentries.org/requests/workshop_request/396/ - it's a request that contains multiple additional contacts. Granted, it looks terrible - should be displayed as bullet points [sidenote: I added a bug #1573 for this]. But it does look like we accept multiple additional contacts in WRF form(s).

It looks like additional_contact from WorkshopRequest isn't being populated further to contact field in Event. I think we can somewhat easily change this.

@fmichonneau
Copy link
Contributor

@pbanaszkiewicz Would AMY parse the email addresses correctly if there were comma-separated in the website metadata? or should only the first address be included in the metadata?

@pbanaszkiewicz
Copy link
Contributor

@fmichonneau the quickest & easiest solution is to display comma-separated addresses in contact field separately (ie. only on HTML level), but it wouldn't mean that AMY started interpreting these separate addresses individually.

@fmichonneau
Copy link
Contributor

@pbanaszkiewicz I updated the workshop template: now, when multiple addresses are provided for the contacts, they are separated by a | like other fields (see carpentries/workshop-template@0594d9a). This should make the import of these addresses easier on the AMY side.

@pbanaszkiewicz pbanaszkiewicz self-assigned this Apr 26, 2020
@pbanaszkiewicz pbanaszkiewicz added this to the v2.12 milestone Apr 26, 2020
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Apr 26, 2020
This fixes carpentries#1568 by changing EventForm.contact widget to Select2TagWidget,
and changing the way this meta tag is handled (i.e. we now handle multiple
values /list/ for it)

Tests are fixed as well, and JS for importing/updating from URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants