Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developer tools, automation, and some tech debt #1875

Open
17 of 31 tasks
pbanaszkiewicz opened this issue Mar 31, 2021 · 0 comments
Open
17 of 31 tasks

Developer tools, automation, and some tech debt #1875

pbanaszkiewicz opened this issue Mar 31, 2021 · 0 comments
Assignees
@pbanaszkiewicz
Labels
component: database (DB) type: maintenance type: optimization

Comments

@pbanaszkiewicz
Copy link
Contributor

pbanaszkiewicz commented Mar 31, 2021 •
edited

Some developer tools and improvements to complete:

  • docker-compose with database and redis
  • pre-commit with black
  • pre-commit with flake8
  • pre-commit with isort
  • GitHub CI workflow for building docs
  • GitHub CI workflow for running tests
  • poetry or pipenv (sticking to pipenv) ([#1875] Pipenv instead of requirements.txt #1965)
  • pyenv (this is developer's choice)
  • GitHub CI workflow for linting with black, flake8 and isort
  • use git flow with release branches not needed, tagging releases is just as good
  • switch to versioning in setup.cfg or pyproject.toml (if acceptable)
  • Implement commitizen
  • remove editor-config support since we have black
  • remove travis-ci config since we have GitHub CI workflow for tests
  • remove checkout HEAD^2 from CodeQL workflow
  • squash old migrations to improve application setup performance
  • move fixtures out of old migrations and into a fixtures file
  • move models out from workshops app into correct apps
  • Update procedures.md steps ([#1875] update procedures.md #1990)
  • add indices to DB fields used for lookups (optimizations)
  • look for bottlenecks (e.g. django-compress on the fly?) EDIT: compress had been taking a long time to build website on dev server, it was turned off
  • figure out why sometimes tests for comments fail with ValueError: Cannot assign "<Site: Site object (2)>": "Comment.site" must be a "Site" instance. ([#1875] Fix Sites framework issue when running tests #2042)
  • Migrate from RQ-Scheduler to RQ v1.2.0+ solution (scheduler included)
  • Enable API for autoemail data
  • Move Autoemail tasks to request API instead of pull directly from DB
  • Add CI/CD for develop branch and test server
  • whitenoise for serving static files (drop django-compressor) (related PR: [#1875] No django-compressor, whitenoise instead #2184)
  • Update static files serving with CloudFront CDN
  • JS prettier - in pre-commit
  • JS prettier - on the codebase
  • JS prettier - in GH workflow linter
@pbanaszkiewicz pbanaszkiewicz self-assigned this Mar 31, 2021
@pbanaszkiewicz pbanaszkiewicz mentioned this issue May 9, 2021
Closed
@pbanaszkiewicz pbanaszkiewicz changed the title Developer tools and automation Developer tools, automation, and some tech debt May 16, 2021
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Pipfile + lock
8f414f3
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Update flake8 pre-commit
574b26c
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile to use pipenv
aad3d4b
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Remove requirements.txt from documentation
5e7e1c7 
...and from workflows.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Add linters to Pipfile
8fa0db5
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile to use pipenv
fe9f5e0
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Remove requirements.txt from documentation
f4c856f 
...and from workflows.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2021
@pbanaszkiewicz
[carpentries#1875] Use only Python3.9
e891fb8
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Add linter GitHub action
7d4cb2e
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Drop requirements.txt completely
0be9866
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Remove config files for linters
b9ae1d7 
Only in the Lint Code Base GH action.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Remove dev_requirements.txt
ed4ad4f 
One dev dependency was missed: pre-commit
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile
07a5e59 
Improvements made to the multistage builds:
1. smaller output image thanks to removal of compilation dependencies
2. base image always with security updates
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2021
@pbanaszkiewicz
[carpentries#1875] Move models from workshops to fiscal
f77c2d0 
Moved models:
* Organization
* Membership
* Member
* MemberRole

From `workshops` application to `fiscal`, where they belong.
pbanaszkiewicz added a commit that referenced this issue Jun 4, 2021
@pbanaszkiewicz
Merge pull request #1966 from pbanaszkiewicz/feature/github-action-li…
1a0556e 
…nter

[#1875] Add linter GitHub action
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 4, 2021
@pbanaszkiewicz
[carpentries#1875] Update README instructions w/ pipenv run
f5b9a31
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Pipfile + lock
f5b06b6
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Update flake8 pre-commit
8d9d0df
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Add linters to Pipfile
8ce34d9
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile to use pipenv
12a11b9
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Remove requirements.txt from documentation
92e3ecd 
...and from workflows.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Use only Python3.9
1cbba77
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Drop requirements.txt completely
6ddb99e
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 7, 2021
@pbanaszkiewicz
[carpentries#1875] Remove dev_requirements.txt
b0a444c 
One dev dependency was missed: pre-commit
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Add linters to Pipfile
59545c2
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile to use pipenv
63abde7
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Remove requirements.txt from documentation
4f0dd55 
...and from workflows.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Use only Python3.9
5589b72
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Drop requirements.txt completely
d865aec
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Remove dev_requirements.txt
c0ec047 
One dev dependency was missed: pre-commit
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update Dockerfile
403ba73 
Improvements made to the multistage builds:
1. smaller output image thanks to removal of compilation dependencies
2. base image always with security updates
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update README instructions w/ pipenv run
913a154
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update Django and a couple of other deps
4da78ee
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update readme steps
81158ef
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Update dependencies
1ac3a2a
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jun 11, 2021
@pbanaszkiewicz
[carpentries#1875] Add deployment dependencies
b2e284c 
* Gunicorn
* boto3
pbanaszkiewicz added a commit that referenced this issue Jun 24, 2021
@pbanaszkiewicz
Merge pull request #1965 from pbanaszkiewicz/feature/pipenv
3c04165 
[#1875] Pipenv instead of requirements.txt
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jul 4, 2021
@pbanaszkiewicz
[carpentries#1875] Move version to AMY's root __init__.py
0ff5701 
It didn't need to be stored inside `workshops` application.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Jul 4, 2021
@pbanaszkiewicz
[carpentries#1875] Updated procedures.md
b2c7817 
Irrelevant/outdated sections removed or rephrased.

Deployment steps moved to deployment repository.
pbanaszkiewicz added a commit that referenced this issue Jul 24, 2021
@pbanaszkiewicz
Merge pull request #1990 from pbanaszkiewicz/feature/1875-update-proc…
9cec78c 
…edures.md

[#1875] update `procedures.md`
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Aug 29, 2021
@pbanaszkiewicz
[carpentries#1875] Fix Sites framework issue when running tests
784fb06 
The issue appeared when running tests in parallel in a fresh database.
Most likely it was due to some junk left in sites cache after
migrations. The solution clears the cache whenever Sites framework is
used.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Aug 29, 2021
@pbanaszkiewicz
[carpentries#1875] Fix Sites framework issue when running tests
faf0e8f 
The issue appeared when running tests in parallel in a fresh database.
Most likely it was due to some junk left in sites cache after
migrations. The solution clears the cache whenever Sites framework is
used.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Aug 29, 2021
@pbanaszkiewicz
[carpentries#1875] Update dependencies
79d8db4
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Aug 29, 2021
@pbanaszkiewicz
[carpentries#1875] Update dependencies
79be4b2
pbanaszkiewicz added a commit that referenced this issue Sep 8, 2021
@pbanaszkiewicz
Merge pull request #2042 from pbanaszkiewicz/feature/1875-sites-cache…
cddc999 
…-issue

[#1875] Fix Sites framework issue when running tests
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2022
@pbanaszkiewicz
[carpentries#1875] Drop django-compressor
d9a6d35 
This change results in significant performance boost in DEBUG mode.
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2022
@pbanaszkiewicz
[carpentries#1875] Enable whitenoise
fe1ce6d
@pbanaszkiewicz pbanaszkiewicz mentioned this issue May 29, 2022
Merged
1 task
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 29, 2022
@pbanaszkiewicz
[carpentries#1875] Fix font-awesome fonts
0acc01c
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2022
@pbanaszkiewicz
[carpentries#1875] Run collectstatic for tests
7cffe4a
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2022
@pbanaszkiewicz
[carpentries#1875] Install FE deps for tests
5cae24a
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue May 30, 2022
@pbanaszkiewicz
[carpentries#1875] Faster tests after introduction of whitenoise
9d3d043 
Whitenoise has impact on the test suite. One way to work around it is to
turn on autorefresh during testing.
For details see:
https://whitenoise.evans.io/en/stable/django.html#whitenoise-makes-my-tests-run-slow
pbanaszkiewicz added a commit that referenced this issue May 30, 2022
@pbanaszkiewicz
Merge pull request #2184 from pbanaszkiewicz/feature/1875-no-compressor
a118fd6 
[#1875] No django-compressor, whitenoise instead
pbanaszkiewicz added a commit that referenced this issue Jun 8, 2022
@pbanaszkiewicz
[#1875] Add static host configuration for CDN
9c6cef4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
component: database (DB) type: maintenance type: optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbanaszkiewicz