Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'DC' used to be an option for 'tag' -- disappeared from list? #744

Closed
maneesha opened this issue Apr 7, 2016 · 14 comments
Closed

'DC' used to be an option for 'tag' -- disappeared from list? #744

maneesha opened this issue Apr 7, 2016 · 14 comments

Comments

@maneesha
Copy link
Contributor

@maneesha maneesha commented Apr 7, 2016

See:

image

@aditnryn
Copy link

@aditnryn aditnryn commented Apr 7, 2016

For what it's worth,
The DC tag could have been deleted.
New tags can be added through the admin interface.
/workshops/admin/workshops/tag/add/ URL adds a new tag.

@gvwilson
Copy link
Contributor

@gvwilson gvwilson commented Apr 7, 2016

@aditnryn
Copy link

@aditnryn aditnryn commented Apr 7, 2016

Accidentally deleted from the admin interface by an admin user? That was just a hypothesis.
I cannot think of any other way a tag can be deleted.

@pbanaszkiewicz would answer it better than me.

@maneesha
Copy link
Contributor Author

@maneesha maneesha commented Apr 7, 2016

Deleted by whom??

That's why I raised this issue. I know it's easy to add a tag but it's a problem that it got deleted. I've never gone into the admin panel.

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

Looking into this issue…

@gvwilson
Copy link
Contributor

@gvwilson gvwilson commented Apr 7, 2016

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

Logs don't show anyone accessing the admin interface in order to remove the tag, which means there's some awful bug in the code that removed the tag.

I'll:

  1. bisect the backups to find correct time the removal happened and then check what requests caused it
  2. retrieve lost data
  3. review our models' on_delete behavior.

It may take me some hours before I'll retrieve the lost data (ie. workshops that were marked DC).

@pbanaszkiewicz pbanaszkiewicz self-assigned this Apr 7, 2016
@pbanaszkiewicz pbanaszkiewicz added this to the v1.5.2 milestone Apr 7, 2016
@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

@maneesha thank you for reacting this quick, by the way. The lost happened probably in the last 24h.

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

Found the error. It's in the event merge procedure and you can reproduce it by setting base object for merge to object A (ie. Field to "Use A"), and strategy for tags to "Use B".

EDIT: not sure though how it behaves when both events have different tags; I only tested it for "DC" "DC".

@gvwilson
Copy link
Contributor

@gvwilson gvwilson commented Apr 7, 2016

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

The data was retrieved.

@gvwilson write up and publish somewhere?

@gvwilson
Copy link
Contributor

@gvwilson gvwilson commented Apr 7, 2016

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 7, 2016

Excellent work.

And terrible too, because the bug is in code I wrote :-)

@pbanaszkiewicz
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz commented Apr 8, 2016

Forgot to close this issue yesterday :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.