Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After logout, redirect to the login page with a message #867

Closed
pbanaszkiewicz opened this issue Jun 30, 2016 · 4 comments · Fixed by #1323
Closed

After logout, redirect to the login page with a message #867

pbanaszkiewicz opened this issue Jun 30, 2016 · 4 comments · Fixed by #1323
Assignees
@pbanaszkiewicz
Labels
type: enhancement
Milestone
v2.1

Comments

@pbanaszkiewicz
Copy link
Contributor

I'd work on this for v1.6.1, but as it turns out Django changes auth views (we use them for login / logout) in the v1.11 release, so if we wait a little we may get a better implementation.
@gvwilson
Copy link
Contributor

Any progress?

@chrismedrela
Copy link
Contributor

Django 1.10 introduces LOGOUT_REDIRECT_URL, so this may be trivial change if we upgrade from Django 1.9.

@gvwilson
Copy link
Contributor

gvwilson commented Aug 1, 2016

@pbanaszkiewicz any thoughts on upgrading to Django 1.10?

@pbanaszkiewicz
Copy link
Contributor Author

pbanaszkiewicz commented Aug 2, 2016 •
edited

Will do, especially since Django 1.10 was recently released, but not soon.

@pbanaszkiewicz pbanaszkiewicz added this to the v2.1 milestone Aug 12, 2018
pbanaszkiewicz added a commit to pbanaszkiewicz/amy that referenced this issue Aug 12, 2018
@pbanaszkiewicz
Fix carpentries#867 (After logout, redirect to the login page with a …
19647b0 
…message)

This commit fixes the issue using Django's very own `logout_then_login`
view, but extends it with messaging capabilities.
@pbanaszkiewicz pbanaszkiewicz mentioned this issue Aug 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbanaszkiewicz pbanaszkiewicz

Labels
type: enhancement
Projects
None yet
Milestone
v2.1
Development

Successfully merging a pull request may close this issue.

Upgrade Django to v2.1, include some additional changes pbanaszkiewicz/amy
3 participants
@pbanaszkiewicz @gvwilson @chrismedrela