feature(Profile Archival): Added social auth removal to Person archive. #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauryndbrown
added
python
pbanaszkiewicz
requested changes
May 3, 2021
| self.user.save() | ||
| self.user.synchronize_usersocialauth() |
There was a problem hiding this comment.
Looks like this would call the GitHub API for this user. Can you mock the underlying Github class (see github_auth.py for details)?
There was a problem hiding this comment.
Gotcha added it.
| # Add social auth to admin | ||
| self.admin.github = "admin-github" | ||
| self.admin.is_active = True | ||
| self.admin.synchronize_usersocialauth() |
There was a problem hiding this comment.
Does admin account in tests require sync with GitHub?
There was a problem hiding this comment.
Not necessarily. I mostly have just done it in case there was any difference between the way the admin works in comparison to the normal user.
lauryndbrown
force-pushed
the
1920/archived-users-cannot-login-with-github
branch
from
60c5a6d
to
72c8327
Compare
lauryndbrown
force-pushed
the
1920/archived-users-cannot-login-with-github
branch
from
72c8327
to
b9d020a
Compare
pbanaszkiewicz
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920
Before Archival:
After Archival:
