On Fri, Apr 03, 2015 at 03:24:24PM -0700, Aditya Narayan wrote:
I am not sure if this fix is the most elegent way to achieve it.
Yeah, hitting the database to revert the unsaved changes doesn't seem
right, but I can't think of a better way either. Personally, I don't
think setting the title for the edit-page is worth an extra database
query, so I'd just drop this and go back to generic, model-level
titles (or just have the title be ‘amy’). If we want to keep the
entry-specific titles, this change is probably fine.
@wking Yes, I agree with you. I am against generating database query for changing the title. I would go for generic titles, unless there is another way to achieve the same without hitting the database.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.