Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined method `[]' for nil with no options in serializable_hash #83

Closed
wants to merge 1 commit into from

Conversation

relevante
Copy link

See #82

@rmm5t
Copy link
Member

rmm5t commented Jan 16, 2013

@relevante Are you sure this wasn't already fixed in #81? Did you test against the master branch already or only v0.3.0?

@relevante
Copy link
Author

Yes, was fixed there. I didn't notice because the nil options was checked in the method instead of defaulting to nil. Thanks!

@relevante relevante closed this Jan 16, 2013
@relevante
Copy link
Author

It's still here: https://github.com/jnicklas/carrierwave-mongoid/blob/master/lib/carrierwave/mongoid.rb on line 64.

Sent from my iPad

On Jan 16, 2013, at 2:01 PM, Ryan McGeary notifications@github.com wrote:

@relevante Are you sure this wasn't already fixed in #81? Did you test against the master branch already or only v0.3.0?


Reply to this email directly or view it on GitHub.

@relevante
Copy link
Author

Actually I take that back. Looks like !options was added below instead. Thanks!

Sent from my iPad

On Jan 16, 2013, at 2:01 PM, Ryan McGeary notifications@github.com wrote:

@relevante Are you sure this wasn't already fixed in #81? Did you test against the master branch already or only v0.3.0?


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants