New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting a deprecation warnings for BeNoLargerThan #1437

Closed
torstenb opened this Issue Aug 18, 2014 · 11 comments

Comments

Projects
None yet
10 participants
@torstenb

torstenb commented Aug 18, 2014

Getting the following deprecation warning:

CarrierWave::Test::Matchers::BeNoLargerThan implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
@thomasfedb

This comment has been minimized.

Show comment
Hide comment
@thomasfedb

thomasfedb Aug 18, 2014

Contributor

I think all this needs is a new gem release, which would be greatly appreciated and much preferred to resorting to using a git: ... reference in one's Gemfile. Time for 0.10.1 perhaps?

Contributor

thomasfedb commented Aug 18, 2014

I think all this needs is a new gem release, which would be greatly appreciated and much preferred to resorting to using a git: ... reference in one's Gemfile. Time for 0.10.1 perhaps?

@ArturT

This comment has been minimized.

Show comment
Hide comment
@ArturT

ArturT Aug 19, 2014

Contributor

+1

Contributor

ArturT commented Aug 19, 2014

+1

@bensie

This comment has been minimized.

Show comment
Hide comment
@bensie

bensie Aug 21, 2014

Member

In the meantime, please continue using github: "carrierwaveuploader/carrierwave" in your Gemfile.

Member

bensie commented Aug 21, 2014

In the meantime, please continue using github: "carrierwaveuploader/carrierwave" in your Gemfile.

@bensie bensie closed this Aug 21, 2014

@jaredbeck

This comment has been minimized.

Show comment
Hide comment
@jaredbeck

jaredbeck Sep 4, 2014

Contributor

Any word on a new release? Can we expect a 0.10.1 or a 0.11.0? Thanks!

Contributor

jaredbeck commented Sep 4, 2014

Any word on a new release? Can we expect a 0.10.1 or a 0.11.0? Thanks!

@thomasfedb

This comment has been minimized.

Show comment
Hide comment
@thomasfedb

thomasfedb Sep 4, 2014

Contributor

Contributor

thomasfedb commented Sep 4, 2014

@brodock

This comment has been minimized.

Show comment
Hide comment
@brodock

brodock Sep 23, 2014

For semantic versioning reasons, I believe that 0.11.0 makes more sense, as we are breaking dependencies and requiring new RSpec version.

This is also a good oportunity to start using http://semver.org/, and make a public statement of it on README.

brodock commented Sep 23, 2014

For semantic versioning reasons, I believe that 0.11.0 makes more sense, as we are breaking dependencies and requiring new RSpec version.

This is also a good oportunity to start using http://semver.org/, and make a public statement of it on README.

@jrmyward

This comment has been minimized.

Show comment
Hide comment
@jrmyward

jrmyward May 5, 2016

Did this not make it into the 0.11.0 release? I'm still getting the deprecation warnings after updating the gem.

jrmyward commented May 5, 2016

Did this not make it into the 0.11.0 release? I'm still getting the deprecation warnings after updating the gem.

@tom-lord

This comment has been minimized.

Show comment
Hide comment
@tom-lord

tom-lord Aug 3, 2016

Contributor

I'm still getting deprecation warnings, too. Using 0.11.2.

Contributor

tom-lord commented Aug 3, 2016

I'm still getting deprecation warnings, too. Using 0.11.2.

@prrrnd

This comment has been minimized.

Show comment
Hide comment
@prrrnd

prrrnd Aug 23, 2016

Also getting deprecation warnings for CarrierWave::Test::Matchers::HaveDimensions, using 0.11.2

prrrnd commented Aug 23, 2016

Also getting deprecation warnings for CarrierWave::Test::Matchers::HaveDimensions, using 0.11.2

@Bastes

This comment has been minimized.

Show comment
Hide comment
@Bastes

Bastes Oct 28, 2016

Also getting the deprecation warnings for 0.11.2.

Bastes commented Oct 28, 2016

Also getting the deprecation warnings for 0.11.2.

@Bastes

This comment has been minimized.

Show comment
Hide comment
@Bastes

Bastes Oct 28, 2016

Hey guys, I've sent a little pull request to allow all of us who aren't really ready to get to a 1.0.0-beta working on their production projects: #2054

Bastes commented Oct 28, 2016

Hey guys, I've sent a little pull request to allow all of us who aren't really ready to get to a 1.0.0-beta working on their production projects: #2054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment