Update get_object_url to Fog 1.0 API #483

Merged
merged 1 commit into from Oct 7, 2011

Conversation

Projects
None yet
2 participants
Contributor

scottmessinger commented Oct 7, 2011

Change get_object_url to get_object_https_url because get_object_url is deprecated in fog 1.0

bensie added a commit that referenced this pull request Oct 7, 2011

Merge pull request #483 from scottmessinger/https_url
Update get_object_url to Fog 1.0 API

@bensie bensie merged commit 7e5913b into carrierwaveuploader:master Oct 7, 2011

Owner

bensie commented Oct 7, 2011

I know I already merged and closed this, but do you by chance know when get_object_https_url was added (which version of Fog)? I'm all about fixing deprecation warnings, but want to maintain a good amount of backward compatibility with Fog - 1.0 is very new and the current Carrierwave gemspec doesn't specify a minimum Fog version.

/cc @geemus

Contributor

scottmessinger commented Oct 7, 2011

Great question. It appears to have been added between 0.9 and 0.10

It appears this is the first time the method was committed:
geemus/fog@50cbeea

-Scott

On Thu, Oct 6, 2011 at 11:44 PM, James Miller <
reply@reply.github.com>wrote:

I know I already merged and closed this, but do you by chance know when
get_object_https_url was added (which version of Fog)? I'm all about fixing
deprecation warnings, but want to maintain a good amount of backward
compatibility with Fog - 1.0 is very new and the current Carrierwave gemspec
doesn't specify a minimum Fog version.

/cc @geemus

Reply to this email directly or view it on GitHub:
jnicklas#483 (comment)

Owner

bensie commented Oct 7, 2011

Ok - I will patch Carrierwave to support old and new in the morning. New iPhone ordered, time for bed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment