added an override to allow fog configuration per uploader #870

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@dei79
Contributor
dei79 commented Oct 13, 2012

Added an override to allow to configure the uploader specific
configurations, e.g. S3 bucket or S3 account per uploader instance in
addition to the general configuration from the initializers

I use this to upload files from one form into two different AWS accounts.

@dei79 dei79 added an override to allow fog configuration per uploader
Added an override to allow to configure the uploader specific
configurations, e.g. S3 bucket or S3 account per uploader instance in
addition to the general configuration from the initializers
f78ebae
@thiagofm
Member

@dei79 can you please write some test cases for it?

Thanks.

@dei79 dei79 Added missing spec for overrides
Added some specs to ensure that the override works and does not
influence not overridden attributes
f2eb6f9
@dei79
Contributor
dei79 commented Oct 19, 2012

I added some spec and hope this helps

Dirk Eisenberg fixed issue with boolean variables
The wrong validation was used to identify if an override exists or not
so sometime the system ignored the override
258cd74
@dei79
Contributor
dei79 commented Oct 19, 2012

I found an other issue with the check if an override exists or not. The spec is added to the last submit and the fix of course

@thiagofm
Member

Hello @dei79

Can you please remove the .gitignore change and keep your commits squashed?

Thanks.

Dirk Eisenberg and others added some commits Oct 19, 2012
@dei79
Contributor
dei79 commented Oct 19, 2012

ok I will create a new pull request with the squashed branch

@dei79 dei79 closed this Oct 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment